Skip to content

Conversation

@Flash-Shivam
Copy link

This PR solves this issue #58

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@CTY-git CTY-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution. But I believe the change should be in the step level rather than the scm client level. Could you change your PR to reflect this?

@patched-codes
Copy link

patched-codes bot commented Aug 27, 2024

File Changed: patchwork/common/client/scm.py

Details: Use f-strings with caution when logging error messages that may contain user input.

Affected Code Snippet:

logger.warn(f"Failed to get issue: {e}")

Start Line: 353

End Line: 353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants