add retry strategy repository #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBadura
force-pushed
the
retry-strategy-repository
branch
from
cf74d34 to
984cd0e
Compare
DanielBadura
approved these changes
Feb 19, 2025
Member
DanielBadura
left a comment
DanielBadura
left a comment
There was a problem hiding this comment.
Last thing: what happens if both options are configured? We should throw then an excpetion, right?
DavidBadura
force-pushed
the
retry-strategy-repository
branch
from
984cd0e to
0c35c32
Compare
Member
Author
|
No, otherwise I have to make the option nullable too. The deprecation notice should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs: patchlevel/event-sourcing#700