Skip to content

add attributes support for aggregates #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielBadura merged 15 commits into from
Jan 5, 2022
Merged

add attributes support for aggregates #34

DanielBadura merged 15 commits into from
Jan 5, 2022

Conversation

@MarcoGiesen
Copy link
Contributor

@MarcoGiesen MarcoGiesen commented Dec 28, 2021 •
edited by DavidBadura
Loading

fix #15

@DavidBadura DavidBadura marked this pull request as draft December 28, 2021 14:56
@DavidBadura DavidBadura changed the title WIP: add attributes support for aggregates add attributes support for aggregates Dec 28, 2021
@DavidBadura DavidBadura added this to the 1.2.0 milestone Dec 28, 2021
@DavidBadura DavidBadura added the enhancement New feature or request label Dec 28, 2021
DavidBadura
DavidBadura reviewed Dec 31, 2021
View reviewed changes
DavidBadura
DavidBadura reviewed Dec 31, 2021
View reviewed changes
DavidBadura
DavidBadura reviewed Dec 31, 2021
View reviewed changes
DavidBadura
DavidBadura reviewed Dec 31, 2021
View reviewed changes
DavidBadura
DavidBadura reviewed Dec 31, 2021
View reviewed changes
@MarcoGiesen
added better reflection to load and check for the aggregate attribute…
02be3ee 
…, first draft of class loading
@MarcoGiesen
moved attribute loading into loader class, changed aggregate paths to…
7f8b50d 
… array instead of scalar value
@MarcoGiesen
fixed loader for snapshot store attribute, added test entry for setti…
4bbab19 
…ng the snapstore with the atribute
@MarcoGiesen
removed roave better reflection, added symfony finder, use reflection…
52fecf2 
… classes to check and load attribute
@MarcoGiesen
removed path depdency in loader constructor, added path argument for …
0d15087 
…load method, added aggregate as filter for getAttributes on reflection, simplified getSnapshotStore
@MarcoGiesen
added conditon to only load aggregate path, if non empty array is sub…
150c2d2 
…mitted
@MarcoGiesen
add configuration and test to normalize single path values into array
b36a886
@MarcoGiesen
added invalid argument exception for duplicated aggregate names for a…
bebb9f5 
…ttributes itself and merging of paths + configured array in yaml
@MarcoGiesen
mark attribute aggregate loader as final
f3e7b1d
@MarcoGiesen
add docs entry for aggregate attribute below how to register aggregat…
48445f7 
…e roots
@MarcoGiesen
updated composer lock
373c4f0
@DavidBadura DavidBadura marked this pull request as ready for review January 3, 2022 14:46
DanielBadura
DanielBadura reviewed Jan 3, 2022
View reviewed changes
DavidBadura
DavidBadura reviewed Jan 4, 2022
View reviewed changes
@DanielBadura DanielBadura merged commit 884f9cd into patchlevel:1.2.x Jan 5, 2022
@DanielBadura
Copy link
Member

DanielBadura commented Jan 5, 2022

Thanks @MarcoGiesen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

add attributes support to register aggregates

3 participants

@MarcoGiesen @DanielBadura @DavidBadura