Using `merge_orm_schema` with two connections creates incomplete schema

[fritz-gerneth]

Not sure if this belongs here or in the bundle, but the affected code is in this repo.

In our testing environment ./console doctrine:schema:create creates in incomplete schema. The eventstore table is missing in the generated schema.

Setup:

• merge_orm_schema: true
• Two connections, one for the app, one for the event store
• As part of test setup, we run ./console doctrine:schema:update --force --env=test

The generated SQL code does contain the base table for the subscriptions, but not for the event store. I tracked this down to this check. The schema update uses the default connection, not the store connection, hence the store is not set up. Disabling this check makes this function work as expected.

This is also an inconsistency to the SubscriptionStore which does not perform this check, hence the subscriptions table is part of the setup.

We cannot use the ./console event-sourcing:schema:update command, as this will delete the tables created in the main app schema. I suggest to remove this check - it should not be necessary for the schema setup?

[DavidBadura]

We can not simply remove the check, and it is actually more of a bug in the SubscriptionEngine that the check is missing.

We did not consider your case, where two connections point to the same database. But we also have the case where two connections exist with two different databases. In that case, the store would be created in each database, which we also do not want.

We rather need to implement a way to determine whether it is the same database and not same connection. Symfony had a similar issue with the Session/Messenger component: symfony/symfony#48059

In there Solution, they temporarily create a table. I am not sure if that is the best solution.

[fritz-gerneth]

But with merge_orm_schema, this could only be on the same connection, therefore database?

I could also use a separate schema and the ./console event-sourcing:schema:update command - but it then would need to ignore all other tables (and not drop them, because they are not part of THIS schema)

[DavidBadura]

merge_orm_schema is somewhat misleading, which is why we also have an issue to rename it patchlevel/event-sourcing-bundle#260. In reality, it is more like: do not register the schema/migration services yourself (because the DoctrineBundle is optional), but instead use the services from the DoctrineBundle. But the effect is the same, it is possible to merge the event sourcing schema with doctrine orm.

In DoctrineBundle you have the option to have multiple entity managers that use different connections or databases. Therefore, without the check, I do not know in which of the databases the schemas for event sourcing should be created. Symfony had exactly this problem as well.

This PR should solve the problem: #773
I still need to test it myself and write tests for it. But it should also cover your case without you having to filter out all the tables.

[DanielBadura]

Should be fixed with https://github.com/patchlevel/event-sourcing/releases/tag/3.12.0

[fritz-gerneth]

Sorry for the late reply - but this did indeed fix our issue 👍