Skip to content

Conversation

@DavidBadura
Copy link
Member

Replace the RetryOutdatedAggregateCommandBus with a more flexible version. The InstantRetryCommandBus allows you to define default values ​​and now also allows you to specify a list of exceptions that trigger this functionality, not just OutdatedAggregate.

@DavidBadura DavidBadura added this to the 3.12.0 milestone Jun 17, 2025
@DavidBadura DavidBadura requested a review from DanielBadura June 17, 2025 10:32
@DavidBadura DavidBadura added the enhancement New feature or request label Jun 17, 2025
@DavidBadura DavidBadura force-pushed the instant-retry branch 2 times, most recently from ab00efc to 4903a66 Compare June 17, 2025 10:41
@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 77.139ms (±0.00%) | 78.175ms (±0.00%) | -1.33%    | 34.743mb        | 35.275mb   | -1.51%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.614ms (±0.00%)  | 51.488ms (±0.00%)  | -1.70%    | 34.348mb        | 34.348mb   | 0.00%       |
| benchLoad10000Events ()                | 949.900μs (±0.00%) | 933.000μs (±0.00%) | +1.81%    | 34.348mb        | 34.348mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.235s (±0.00%) | 3.249s (±0.00%) | -0.43%    | 46.891mb        | 46.891mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 996.400μs (±0.00%) | 987.600μs (±0.00%) | +0.89%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchLoad10000Events ()                | 56.845ms (±0.00%)  | 58.705ms (±0.00%)  | -3.17%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave1Event ()                     | 1.303ms (±0.00%)   | 1.104ms (±0.00%)   | +18.03%   | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave10000Events ()                | 308.205ms (±0.00%) | 309.829ms (±0.00%) | -0.52%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.281s (±0.00%)    | 8.207s (±0.00%)    | +0.91%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.173s (±0.00%)    | 5.168s (±0.00%)    | +0.08%    | 34.458mb        | 34.458mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.552ms (±0.00%)   | 4.527ms (±0.00%)   | +0.56%    | 37.650mb        | 37.650mb   | 0.00%       |
| benchSave10000Events () | 361.037ms (±0.00%) | 351.753ms (±0.00%) | +2.64%    | 37.653mb        | 37.653mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.028ms (±0.00%)   | 1.007ms (±0.00%)   | +2.10%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchLoad10000Events ()                | 51.868ms (±0.00%)  | 53.634ms (±0.00%)  | -3.29%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchSave1Event ()                     | 1.072ms (±0.00%)   | 1.073ms (±0.00%)   | -0.04%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchSave10000Events ()                | 236.701ms (±0.00%) | 232.826ms (±0.00%) | +1.66%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.072s (±0.00%)    | 8.115s (±0.00%)    | -0.52%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.999s (±0.00%)    | 4.969s (±0.00%)    | +0.61%    | 34.344mb        | 34.344mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.016ms (±0.00%)   | 1.028ms (±0.00%)   | -1.21%    | 35.477mb        | 35.477mb   | 0.00%       |
| benchLoad10000Events ()                | 97.430ms (±0.00%)  | 94.754ms (±0.00%)  | +2.82%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchSave1Event ()                     | 1.491ms (±0.00%)   | 1.491ms (±0.00%)   | -0.05%    | 35.477mb        | 35.477mb   | 0.00%       |
| benchSave10000Events ()                | 268.263ms (±0.00%) | 267.951ms (±0.00%) | +0.12%    | 35.479mb        | 35.479mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.491s (±0.00%)   | 12.276s (±0.00%)   | +1.75%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.272s (±0.00%)    | 9.288s (±0.00%)    | -0.17%    | 35.980mb        | 35.980mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice I really like this approach!

@DavidBadura DavidBadura merged commit 0ad14d9 into 3.12.x Jun 17, 2025
39 of 40 checks passed
@DavidBadura DavidBadura deleted the instant-retry branch June 17, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants