Skip to content

Fix: Make fcntl usage conditional in mcpm share for Windows compatibi… #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Fix: Make fcntl usage conditional in mcpm share for Windows compatibi… #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/mcpm/commands/share.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@ def find_mcp_proxy() -> Optional[str]:

def make_non_blocking(file_obj):
"""Make a file object non-blocking."""
import fcntl

fd = file_obj.fileno()
fl = fcntl.fcntl(fd, fcntl.F_GETFL)
fcntl.fcntl(fd, fcntl.F_SETFL, fl | os.O_NONBLOCK)
if os.name == 'posix':
import fcntl

fd = file_obj.fileno()
fl = fcntl.fcntl(fd, fcntl.F_GETFL)
fcntl.fcntl(fd, fcntl.F_SETFL, fl | os.O_NONBLOCK)
# On other platforms (e.g., Windows), we rely on the behavior of select()
# and the non-blocking nature of readline() on Popen streams,
# or the existing try-except for IOError/OSError.


def wait_for_random_port(process: subprocess.Popen, timeout: int = 20) -> Optional[int]:
Expand Down