[generate_manifest] use GITHUB_TOKEN to create PR & improve commit message #236
Conversation
WalkthroughAuthentication in the CI workflow’s Create Pull Request step switches from secrets.MCPM_PERSONAL_ACCESS_TOKEN to secrets.GITHUB_TOKEN. The auto-generated PR body text is updated: removal of Claude-related attribution lines and addition of “Co-Authored-By: Lucien.” No other workflow logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.github/workflows/generate-manifest.yml (5)
55-61: Fix YAML lint errors: remove trailing spaces in commit message blockYAMLlint flags trailing spaces on Line 57 and Line 59. Clean up the multiline scalar to avoid CI lint failures.
Apply this diff to normalize whitespace:
commit-message: | feat: add manifest for ${{ steps.repo-info.outputs.repo_name }} - + Generated manifest JSON for repository: ${{ github.event.inputs.repo_url || github.event.client_payload.repo_url }} - + Co-Authored-By: Lucien
80-80: The Claude attribution line is still present; remove to match PR objectivePer the PR objective and summary, the Claude attribution should be removed. It remains in the PR body.
Apply this diff to remove it:
- 🤖 Generated with [Claude Code](https://claude.ai/code)
26-29: Consider upgrading setup-python to v5 and enabling pip cacheOptional DX/perf tweak: actions/setup-python@v5 supports built-in caching, which will speed up repeated runs.
- - name: Set up Python - uses: actions/setup-python@v4 - with: - python-version: '3.11' + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.11' + cache: 'pip'
46-49: Harden repo name extraction against trailing slashes and whitespaceMinor robustness. If repo_url ends with a slash or has stray whitespace, branch naming can be impacted.
- REPO_URL="${{ github.event.inputs.repo_url || github.event.client_payload.repo_url }}" - REPO_NAME=$(echo "$REPO_URL" | sed 's/.*github\.com[:/]//' | sed 's/\.git$//' | tr '/' '-') + REPO_URL="$(echo "${{ github.event.inputs.repo_url || github.event.client_payload.repo_url }}" | sed 's/[[:space:]]//g')" + # Strip protocol/host, optional trailing ".git" and any trailing slash + REPO_NAME=$(echo "$REPO_URL" \ + | sed 's/.*github\.com[:/]//' \ + | sed 's/\.git$//' \ + | sed 's:/*$::' \ + | tr '/' '-')
21-25: Checkout token is optional hereactions/checkout uses the workflow’s GITHUB_TOKEN by default. Passing it explicitly is fine; you can also omit the token key to reduce noise.
- name: Checkout repository uses: actions/checkout@v4 - with: - token: ${{ secrets.GITHUB_TOKEN }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/generate-manifest.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/generate-manifest.yml
[error] 57-57: trailing spaces
(trailing-spaces)
[error] 59-59: trailing spaces
(trailing-spaces)
🔇 Additional comments (1)
.github/workflows/generate-manifest.yml (1)
54-54: Switch to GITHUB_TOKEN looks correct given permissions are setUsing GITHUB_TOKEN here is appropriate, and the job-level permissions include contents: write and pull-requests: write, which are required by peter-evans/create-pull-request.
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Type
Enhancement
Description
Switch from personal access token to GITHUB_TOKEN
Update commit co-author from Claude to Lucien
Remove Claude Code generation reference
Diagram Walkthrough
File Walkthrough
generate-manifest.yml
Update token and commit author configuration.github/workflows/generate-manifest.yml
MCPM_PERSONAL_ACCESS_TOKENwithGITHUB_TOKENfor PR creationSummary by CodeRabbit