fix: add should remove optional argument placeholder #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semantic Version CheckPlease ensure your commits follow the Conventional Commits format:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of missing optional arguments by replacing their placeholders with empty strings. Key changes include:
- Updating test assertions to expect empty strings instead of placeholders.
- Modifying the environment filtering logic to include empty values.
- Refactoring the variable replacement logic to directly use empty strings when variables are missing.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_add.py | Updated tests to check for empty string replacement. |
| src/mcpm/schemas/server_config.py | Altered filtering logic to include empty environment values. |
| src/mcpm/commands/server_operations/add.py | Removed prompting logic and replaced missing variables with empty strings. |
Comments suppressed due to low confidence (3)
src/mcpm/commands/server_operations/add.py:352
- [nitpick] Consider renaming 'env_var_name' to a clearer identifier like 'environmentVariableName' for better readability.
processed_env[key] = processed_variables.get(env_var_name, "")
src/mcpm/commands/server_operations/add.py:364
- Using an empty string as a fallback for missing variables might have unintended side effects; please double-check that this behavior is desired in all cases.
replaced_arg = arg.replace(original, processed_variables.get(key, ""))
src/mcpm/schemas/server_config.py:48
- The updated environment filtering logic now includes empty strings; ensure that this adjustment doesn't introduce issues where non-empty values are required.
filtered_env[key] = env_value
Contributor
Semantic Version CheckPlease ensure your commits follow the Conventional Commits format:
|
Contributor
Semantic Version CheckPlease ensure your commits follow the Conventional Commits format:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.