fix(pfEmptyState): Do not redirect when no helpLink url specified #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
requested changes
Jan 9, 2018
| // if no url specified, set url to not redirect. ie. just do urlAction | ||
| ctrl.config.helpLink.url = "javascript:void(0)"; | ||
| } | ||
| ctrl.updateConfig(); |
Member
There was a problem hiding this comment.
This needs to be done in $onChanges as well for the case where the helpLink was added to the config object after init. Maybe do this as part of updateConfig.
Member
Author
There was a problem hiding this comment.
Fixed, added a $doCheck since we need to do a deep compare on the config obj.
dtaylor113
force-pushed
the
empty-state-no-helplink-url
branch
from
8e34368 to
0274412
Compare
jeff-phillips-18
approved these changes
Jan 9, 2018
amarie401
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the pfEmptyState component and specifying a
helpLink, thehelpLinkwill render a<a>. ThehelpLinkcan have aurland/or aurlAction. Problem was ifurlwas not specified, it defaulted to<a hrefwhich redirects to root/.This PR ensures that if no
helpLink.urlspecified, that clicking on the<a>only executes theurlAction(ng-click), and does not redirect and change the browser url. This is a requirement for OpenShift.