fix(ChatbotConversationHistoryNav): Pass search input props#630
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Aug 4, 2025
Merged
fix(ChatbotConversationHistoryNav): Pass search input props#630rebeccaalpert merged 1 commit intopatternfly:mainfrom
rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-630.surge.sh A11y report: https://chatbot-pr-chatbot-630-a11y.surge.sh |
thatblindgeye
approved these changes
Aug 4, 2025
| expect(iconElement).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should be able to have controlled search input', () => { |
Collaborator
There was a problem hiding this comment.
Just a nit based on how react tests are written, but maybe "Should be able to spread search input props when searchInputProps is passed" or something.
Member
Author
There was a problem hiding this comment.
All set! Thank you.
rebeccaalpert
force-pushed
the
searchInput
branch
from
1a2379a to
bff4a80
Compare
thatblindgeye
approved these changes
Aug 4, 2025
Allow for controlled inputs and other customizations by passing props down.
rebeccaalpert
force-pushed
the
searchInput
branch
from
bff4a80 to
2c7851a
Compare
Member
Author
|
Just rebasing after Eric's merged. |
|
🎉 This PR is included in version 6.4.0-prerelease.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
…ly#630) Allow for controlled inputs and other customizations by passing props down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for controlled inputs and other customizations by passing props down.