feat(Message): Allow further customization of Markdown behavior#636
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Aug 4, 2025
Merged
feat(Message): Allow further customization of Markdown behavior#636rebeccaalpert merged 1 commit intopatternfly:mainfrom
rebeccaalpert merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-636.surge.sh A11y report: https://chatbot-pr-chatbot-636-a11y.surge.sh |
nicolethoen
approved these changes
Aug 4, 2025
thatblindgeye
approved these changes
Aug 4, 2025
Collaborator
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Couple nits below, but not blocking for me - just wanted to mention in case you had any thoughts
Comment on lines
+188
to
+189
| /** Disables markdown parsing for message, allowing only text input */ | ||
| disableMarkdown?: boolean; |
Collaborator
There was a problem hiding this comment.
Non-blockers:
- Would we want to include some verbiage in the description for when you may want to disable markdown?
- react-core conventions speaking:
isMarkdownDisabledinstead for the prop name?
Member
Author
There was a problem hiding this comment.
Updated prop name! Let's wait on the verbiage for now and update in a little bit if that's ok.
Allow turning off markdown parsing (going to text-only) or passing additional props to parser react-markdown, such as disallowedElements.
rebeccaalpert
force-pushed
the
markdown-user
branch
from
b80de8b to
12f74d7
Compare
thatblindgeye
approved these changes
Aug 4, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
…ernfly#636) Allow turning off markdown parsing (going to text-only) or passing additional props to parser react-markdown, such as disallowedElements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow turning off markdown parsing (going to text-only) or passing additional props to parser react-markdown, such as disallowedElements. (Using disallowedElements allows for control over what tags can be displayed by parser.) Other options are also now available.