-
Notifications
You must be signed in to change notification settings - Fork 34
feat(UserFeedback): updated compact style and added privacy statement #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(UserFeedback): updated compact style and added privacy statement #771
Conversation
|
Preview: https://chatbot-pr-chatbot-771.surge.sh A11y report: https://chatbot-pr-chatbot-771-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.../module/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithFeedback.tsx
Outdated
Show resolved
Hide resolved
|
@rebeccaalpert updated the example so that the children content wasn't so privacy-statementy. Since the design kit issue asked for different styling on the privacy statement content, both could be valid depending on the use case I think. |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine with me - y'all just may want to push back if folks come in wanting more custom styles. The children prop should take anything.
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small notes for the example microcopy, but nothing too crazy / holding things back
|
|
||
| const children = <>Do not share any personal or other sensitive information in your feedback.</>; | ||
| const children = <>This is additional content.</>; | ||
| const privacyStatement = 'This is a privacy statement text content.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const privacyStatement = 'This is a privacy statement text content.'; | |
| const privacyStatement = 'Do not share any personal or other sensitive information in your feedback.'; |
this isn't necessary, but is the privacy statement intended to be similar to this bit we have in our current examples? If so, I'm just thinking it may be clearer what sort of content might belong here if we stick it as a more tangible example
| role="bot" | ||
| avatar={patternflyAvatar} | ||
| content="This is a message with the feedback card:" | ||
| content="This is a message with the feedback card" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| content="This is a message with the feedback card" | |
| content="This is a message with the feedback card:" |
just adding back to match the others


Closes #769