Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

Closes #769

@patternfly-build
Copy link

patternfly-build commented Nov 21, 2025

@thatblindgeye thatblindgeye marked this pull request as ready for review November 21, 2025 21:08
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-11-21 at 4 38 34 PM Screenshot 2025-11-21 at 4 37 58 PM

I'm not against this per se, but it is weird we have children and a privacy statement in the example and that they're so similar. My question would be where the line is - do we want to just use children? Or do we want to update the text in the demo instead?

@thatblindgeye
Copy link
Contributor Author

@rebeccaalpert updated the example so that the children content wasn't so privacy-statementy. Since the design kit issue asked for different styling on the privacy statement content, both could be valid depending on the use case I think.

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me - y'all just may want to push back if folks come in wanting more custom styles. The children prop should take anything.

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small notes for the example microcopy, but nothing too crazy / holding things back


const children = <>Do not share any personal or other sensitive information in your feedback.</>;
const children = <>This is additional content.</>;
const privacyStatement = 'This is a privacy statement text content.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const privacyStatement = 'This is a privacy statement text content.';
const privacyStatement = 'Do not share any personal or other sensitive information in your feedback.';

this isn't necessary, but is the privacy statement intended to be similar to this bit we have in our current examples? If so, I'm just thinking it may be clearer what sort of content might belong here if we stick it as a more tangible example

role="bot"
avatar={patternflyAvatar}
content="This is a message with the feedback card:"
content="This is a message with the feedback card"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
content="This is a message with the feedback card"
content="This is a message with the feedback card:"

just adding back to match the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chatbot: compact variant for user feedback cards

4 participants