Conversation
| @@ -0,0 +1,296 @@ | |||
| // TODO remove this component it is not good and I don't like that I have to add it | |||
There was a problem hiding this comment.
😆
+1 for long term, it would be nice to have a more out of the box solution and less manual resolution. I don't think it's the worst for now though.
| @@ -0,0 +1,42 @@ | |||
| import React, { useState } from 'react' | |||
| import { convertToReactComponent } from '@patternfly/ast-helpers' | |||
| import * as reactCoreModule from '@patternfly/react-core' | |||
There was a problem hiding this comment.
Would importing the whole module impact performance? Not sure if it's possible / how to import only what each example is using.
There was a problem hiding this comment.
I think it should be ok as this is how the docs framework currently does it in example.js too, but I do share some of the same concern.
One advantage of this route is that we actually shouldn't need to list imports in the md files anymore, but if there is a notable performance impact we could refactor this to something that does require listing imports in the md, or maybe come up with a way of analyzing the imports of the example files themselves 🤔
| export const h4 = ({children}: {children: ReactNode}) => <PFContent component="h4">{children}</PFContent> | ||
| export const h5 = ({children}: {children: ReactNode}) => <PFContent component="h5">{children}</PFContent> | ||
| export const h6 = ({children}: {children: ReactNode}) => <PFContent component="h6">{children}</PFContent> | ||
|
|
There was a problem hiding this comment.
These correspond to the various ##/### syntax for the md/mdx right? We don't need other Content elements like p?
There was a problem hiding this comment.
Ah yeah good catch, we do probably need to add p tags if we want them to get the Content styling.
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
I just realized I was leaving single comments instead of review comments, my bad.
I don't think there are any blockers, just had a few questions
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Closes #17 and actually also closes #23
To test pull this branch, start the dev server, and go to http://localhost:4321/components/accordion