fix(guidelines): punctuation, formatting#1810
Merged
christiemolloy merged 4 commits intopatternfly:masterfrom May 13, 2019
Merged
fix(guidelines): punctuation, formatting#1810christiemolloy merged 4 commits intopatternfly:masterfrom
christiemolloy merged 4 commits intopatternfly:masterfrom
Conversation
Collaborator
|
Deploy preview for pf-next ready! Built with commit bfdda36 |
christiemolloy
suggested changes
May 13, 2019
| @@ -64,77 +64,76 @@ PatternFly follows a two-layer theming system where **global variables** always | |||
| The main reason to have global variables is to maintain consistency. They adhere to the following rules: | |||
|
|
|||
| - They are prefixed with the word `global` and follow the formula `--pf-global--concept--PropertyCamelCase--modifier--state`. | |||
Member
There was a problem hiding this comment.
Above where it says: The component itself never has backgrounds, widths, floats or margins. we give components backgrounds so should we remove that
christiemolloy
approved these changes
May 13, 2019
seanforyou23
suggested changes
May 13, 2019
Contributor
seanforyou23
left a comment
seanforyou23
left a comment
There was a problem hiding this comment.
Couple small nits, other than that this is a really good improvement to the guidelines. Nice job!
seanforyou23
approved these changes
May 13, 2019
Collaborator
|
🎉 This PR is included in version 2.6.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
srambach
referenced
this pull request
in mcoker/patternfly-next
May 28, 2019
* fix(guidelines): punctuation, formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1809