chore(a11y): use tablet viewport size when auditing#1911
Merged
dgutride merged 4 commits intopatternfly:masterfrom Jun 12, 2019
Merged
chore(a11y): use tablet viewport size when auditing#1911dgutride merged 4 commits intopatternfly:masterfrom
dgutride merged 4 commits intopatternfly:masterfrom
Conversation
Collaborator
|
Deploy preview for pf-next ready! Built with commit c4eb4cd |
dgutride
approved these changes
Jun 10, 2019
Member
|
Probably a future idea, but I was wondering if it would be worth making a parameter to the test to say which breakpoint to use. |
Collaborator
|
🎉 This PR is included in version 2.12.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the window size used for the browser that our a11y audit is run against. I've noticed for a while that we get more errors reported on CI that we do locally, was about to file a bug when I realized using a smaller than "maximized" size causes the audit to produce consistent results across both local and CI. We've been wanting to start testing smaller viewports anyway, as many components change in appearance and behavior at smaller dimensions. So, here we use the size of an iPad in portrait orientation.
Should help close; #1602 and #1906