fix(tables): fixed word wrap (iss1791)#1928
Merged
mattnolting merged 2 commits intopatternfly:masterfrom Jun 20, 2019
Merged
Conversation
Collaborator
|
Deploy preview for pf-next ready! Built with commit dbeb8c4 |
christiemolloy
suggested changes
Jun 14, 2019
| background-color: var(--pf-c-table--BackgroundColor); | ||
|
|
||
| td { | ||
| word-break: break-all; |
Member
There was a problem hiding this comment.
Actually Lauren this is my bad will you change this to "word-break: break-word"
I tested this in the table, and some words were breaking when they shouldn't. Using "break-all" breaks every word, but "break-word" breaks just the really long words.
This is with break-all :
This is with "break-word":
Collaborator
|
🎉 This PR is included in version 2.13.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added word-wrap to td's in table, now wraps when on mobile size.
Close #1791