fix(applauncher): add support for right and top alignment#2081
Merged
mcoker merged 2 commits intopatternfly:masterfrom Jul 22, 2019
mattnolting:app-launcher-support-top-right
Merged
fix(applauncher): add support for right and top alignment#2081mcoker merged 2 commits intopatternfly:masterfrom mattnolting:app-launcher-support-top-right
mcoker merged 2 commits intopatternfly:masterfrom
mattnolting:app-launcher-support-top-right
Conversation
Collaborator
|
Deploy preview for pf-next ready! Built with commit e1ee2c0 |
christiemolloy
suggested changes
Jul 22, 2019
Member
christiemolloy
left a comment
christiemolloy
left a comment
There was a problem hiding this comment.
This looks great. One thing, I saw that @jschuler left a comment: "Also consumer should be able to add pf-m-disabled at the button toggle as well as the menu item level" were you going to do this in this PR?
Collaborator
Author
|
@christiemolloy yep, added disabled styling. Disabled already exists at menu-item level. |
mcoker
reviewed
Jul 22, 2019
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Looks good. Just one update to fix the a11y errors.
src/patternfly/components/AppLauncher/examples/app-launcher-disabled-example.hbs
Outdated
Show resolved
Hide resolved
…sabled-example.hbs Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com>
Collaborator
|
🎉 This PR is included in version 2.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1972
relates to: patternfly/patternfly-react#2322