fix(logo): PF logo missing width attribute#2101
Merged
mcoker merged 1 commit intopatternfly:masterfrom Jul 30, 2019
Merged
Conversation
Collaborator
|
Deploy preview for pf-next ready! Built with commit 4a98245 |
|
@mcoker Looks good! |
Member
christiemolloy
left a comment
christiemolloy
left a comment
There was a problem hiding this comment.
should we also update the brand component if this is the width that we recommend for the logo?
Contributor
Author
|
That's just the width for our image. We don't want to impose a width (or height) on comsumers' logos since they can have logos that vary in size. |
christiemolloy
approved these changes
Jul 24, 2019
redallen
approved these changes
Jul 25, 2019
Collaborator
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2100