Skip to content

fix(page): take main elements grid-area value out of custom property#2137

Merged
mattnolting merged 1 commit intopatternfly:masterfrom
mcoker:issue-2136
Aug 7, 2019
Merged

fix(page): take main elements grid-area value out of custom property#2137
mattnolting merged 1 commit intopatternfly:masterfrom
mcoker:issue-2136

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Aug 6, 2019

fixes #2136

@mcoker mcoker requested a review from mattnolting August 6, 2019 22:22
@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 6, 2019

Deploy preview for pf-next ready!

Built with commit 51acb72dea5aeeeb693ae9166f8afc729d609c2b

https://deploy-preview-2137--pf-next.netlify.com

@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 6, 2019

PatternFly-Next preview: https://patternfly-next-pr-2137.surge.sh

@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 6, 2019

Deploy preview for pf-next ready!

Built with commit 1bd2cbd

https://deploy-preview-2137--pf-next.netlify.com

@mcoker
Copy link
Contributor Author

mcoker commented Aug 6, 2019

You can verify the broken behavior by opening a page demo's codepen link and seeing the layout is broken.

Then you can verify the fix by removing the link to https://unpkg.com/@patternfly/patternfly/patternfly.min.css in the codepen's CSS, check out this branch, run npm run build-patternfly, and copy the contents of dist/patternfly.min.css into the CSS panel in the codepen.

mattnolting
mattnolting approved these changes Aug 7, 2019
View reviewed changes
Copy link
Collaborator

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to replicate desired functionality. LGTM 👍

@mattnolting mattnolting merged commit 4060b59 into patternfly:master Aug 7, 2019
@redallen
Copy link
Contributor

redallen commented Aug 7, 2019

🎉 This PR is included in version 2.25.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the issue-2136 branch December 16, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoker @patternfly-build @redallen @mattnolting