chore(deps): update gulp and bump deps#2201
Merged
dgutride merged 3 commits intopatternfly:masterfrom Aug 29, 2019
redallen:chore/deps
Merged
chore(deps): update gulp and bump deps#2201dgutride merged 3 commits intopatternfly:masterfrom redallen:chore/deps
dgutride merged 3 commits intopatternfly:masterfrom
redallen:chore/deps
Conversation
Collaborator
|
PatternFly-Next preview: https://patternfly-next-pr-2201.surge.sh |
Member
|
nice job - what do you think about updating the engines values in package.json? |
Contributor
Author
|
I think we still support Node 8, we are just delivering on our promise of supporting |
Contributor
Author
|
No diff in the min CSS comapred to @patternfly/patternfly 2.27.1: ➜ patternfly-react-seed git:(chore/text-input-example) ✗ diff node_modules/@patternfly/patternfly/patternfly.min.css ~/src/patternfly-next/dist/patternfly.min.css
➜ patternfly-react-seed git:(chore/text-input-example) ✗ echo $?
0 |
mcoker
approved these changes
Aug 28, 2019
Contributor
Author
|
🎉 This PR is included in version 2.27.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2039 . Node 10 compatible now.
We should consider replacing some of the
gulp-*plugins with our own versions as they aren't that hard to implement in Gulp 4. This way we control the versions ofnode-sassorcssminwe use in building our CSS.