Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MenuToggle): consumed Penta updates #10097

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Feb 21, 2024

What: Closes #9986
Codemod

This also bumps the Core versions

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 21, 2024

@kmcfaul kmcfaul linked an issue Feb 21, 2024 that may be closed by this pull request
@thatblindgeye thatblindgeye force-pushed the iss9986_menuTogglePenta branch from ef3e161 to 225545a Compare February 26, 2024 16:39
@thatblindgeye thatblindgeye requested review from mattnolting, tlabaj, kmcfaul, a team, lboehling and kaylachumley and removed request for a team February 26, 2024 16:56
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, saw one bug

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just an extra space in the docs, but not a blocker

@@ -29,7 +29,7 @@ import { MenuToggle } from '@patternfly/react-core';

### Expanded toggle

When a user selects a toggle, it becomes expanded and is styled with a blue underline. To flag expanded toggles, and apply expanded styling, use the `isExpanded` property .
When a user selects a toggle, it becomes expanded and is styled with a blue underline. To flag expanded toggles, and apply expanded styling, use the `isExpanded` property .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space at the end of the line

Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work, thank you! LPTM

@wise-king-sullyman wise-king-sullyman self-requested a review March 4, 2024 20:37
@andrew-ronaldson andrew-ronaldson self-requested a review March 12, 2024 19:19
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 4a8f446 into patternfly:v6 Mar 12, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@6.0.0-alpha.41
  • @patternfly/react-core@6.0.0-alpha.41
  • @patternfly/react-docs@7.0.0-alpha.43
  • @patternfly/react-drag-drop@6.0.0-alpha.22
  • @patternfly/react-integration@6.0.0-alpha.22
  • demo-app-ts@5.1.1-alpha.40
  • @patternfly/react-table@6.0.0-alpha.41

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume Penta tokens: Menu toggle
7 participants