chore(Td): rename disable prop in TdSelectType and TdActionsType #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
jenny-s51
approved these changes
Apr 19, 2023
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Nice work @adamviktora ! LGTM
thatblindgeye
approved these changes
Apr 19, 2023
gitdallas
approved these changes
Apr 20, 2023
Contributor
gitdallas
left a comment
gitdallas
left a comment
There was a problem hiding this comment.
great job, i have some nits/questions but would be fine merging
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-pf-codemods/lib/rules/v5/td-TdSelectType-TdActionsType-rename-disable.js
Outdated
Show resolved
Hide resolved
adamviktora
force-pushed
the
TdSelectType
branch
from
c5610b6 to
28d6e5d
Compare
thatblindgeye
approved these changes
Apr 24, 2023
wise-king-sullyman
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #347 and closes #354