-
Notifications
You must be signed in to change notification settings - Fork 30
Closed
Labels
bugSomething isn't workingSomething isn't working
Milestone
Description
Is this a new component or an extension of an existing one?
This is an enhancement of an existing component -- SkeletonTable.
Describe the feature
Addition of a few props such that Skeleton table would resemble the loaded table more (prop names are just suggestions to get the idea across):
hasCheckbox/isSelectable
-- boolean prop which will make Skeleton table contain checkboxes on the leftisExpandible
-- boolean prop which will make Skeleton table contain expandable caret icons on the leftsortingIndicator/sortIndex
-- some way (with index or column name) to make the currently sorted column header blue (this makes the user experience when changing pages much smoother), this would also probably require column prop to be an array of objects (for each column: title and whether the column is sortable -- thus displaying gray arrow next to column title) instead of current array of strings (just column titles)
Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
We used this custom SkeletonTable implementation from https://github.com/RedHatInsights/frontend-components before it was removed in favour of PF5 SkeletonTable. It supported sorting indication and checkboxes, but not expandable buttons.
This is the code for the custom components before it was replaced.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done