Skip to content

SkeletonTable - add props for sort indicators, checkboxes and expand button #86

@leSamo

Description

@leSamo

Is this a new component or an extension of an existing one?
This is an enhancement of an existing component -- SkeletonTable.

Describe the feature
Addition of a few props such that Skeleton table would resemble the loaded table more (prop names are just suggestions to get the idea across):

  • hasCheckbox/isSelectable -- boolean prop which will make Skeleton table contain checkboxes on the left
  • isExpandible -- boolean prop which will make Skeleton table contain expandable caret icons on the left
  • sortingIndicator/sortIndex -- some way (with index or column name) to make the currently sorted column header blue (this makes the user experience when changing pages much smoother), this would also probably require column prop to be an array of objects (for each column: title and whether the column is sortable -- thus displaying gray arrow next to column title) instead of current array of strings (just column titles)

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
We used this custom SkeletonTable implementation from https://github.com/RedHatInsights/frontend-components before it was removed in favour of PF5 SkeletonTable. It supported sorting indication and checkboxes, but not expandable buttons.
Screenshot from 2024-01-11 14-04-00

This is the code for the custom components before it was replaced.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions