Display PF table in DataView example #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
reviewed
May 21, 2024
| export interface UseDataViewPaginationProps { | ||
| page?: number; | ||
| perPage: number; | ||
| } |
Contributor
There was a problem hiding this comment.
Why is perPage required but page optional? I think both should be optional IMO.
Collaborator
Author
There was a problem hiding this comment.
I think we don't want to introduce default values for perPage - they can vary from use case to use case. For page I think it is fine to keep it optional since it is usually 1 at the beginning.
Hyperkid123
approved these changes
May 21, 2024
|
🎉 This PR is included in version 1.0.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nicolethoen
approved these changes
May 21, 2024
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHCLOUD-32250
useDataViewPaginationhook to manage the pagination state (for now without URL) management