chore(deps): fix dep versioning, conflicts, type #16
Conversation
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
LGTM only a question if we should use undefined instead of null
| section: "extensions", | ||
| subsection: "", | ||
| source: "design-guidelines", | ||
| tabName: null, |
There was a problem hiding this comment.
should we use undefined instead?
There was a problem hiding this comment.
Hmm, I think that tabName value is just coming from the docs framework, and it's coming back as null because we don't define a specific one. It's just showing up as a change here because I bumped the docs framework version.
But yeah that seems like it might be a change we want to make in the docs framework.
There was a problem hiding this comment.
Yeah that frontmatter value is coming from this PR in org https://github.com/patternfly/patternfly-org/pull/3394/files
|
🎉 This PR is included in version 1.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.87.101 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addresses dependency concerns in #14