Skip to content

Conversation

@dlabaj
Copy link
Contributor

@dlabaj dlabaj commented May 4, 2023

This is an alpha release candidate for PatternFly 5. We are removing the dry run so that it will release to npm.

This is an alpha release candidate for PatternFly 5
@nicolethoen
Copy link
Collaborator

Based on the release.yml, I'm concerned that this is going to be releasing from both v4 and main branches on the same release channel?

And the v4 branch does not have a reference to running the release job when things are merged to it in it's release.yml.

have you tried doing a dry run from the v4 branch to confirm that it will release its own prerelease version on a different channel (not alpha)?

@dlabaj
Copy link
Contributor Author

dlabaj commented May 5, 2023

Based on the release.yml, I'm concerned that this is going to be releasing from both v4 and main branches on the same release channel?

And the v4 branch does not have a reference to running the release job when things are merged to it in it's release.yml.

have you tried doing a dry run from the v4 branch to confirm that it will release its own prerelease version on a different channel (not alpha)?

I believe you are right. https://github.com/patternfly/react-user-feedback/blob/v4/packages/module/release.config.js. Making an update on the v4 branch now. @wise-king-sullyman Do we even need the v4 infomration on this branch?
branches: [{ name: 'v4', channel: 'prerelease' }, { name: 'main', channel: 'alpha', prerelease: 'alpha' }],
can we do this instead?
branches: [{ name: 'main', channel: 'alpha', prerelease: 'alpha' }],

@dlabaj
Copy link
Contributor Author

dlabaj commented May 5, 2023

@nicolethoen @wise-king-sullyman Here's the updates I made to the v4 branch. #48

@dlabaj dlabaj merged commit 33d996f into patternfly:main May 5, 2023
@dlabaj
Copy link
Contributor Author

dlabaj commented May 5, 2023

After speaking with Nicole and Austin this fix is fine we need the #48 PR on the v4 branch however.

@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 5.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants