Skip to content

recursion error: highlighting test issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

recursion error: highlighting test issues #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47cf8da
Create recursion_error.feature
paul-ri Jun 20, 2025
6ae8f79
Create recursion_error.py
paul-ri Jun 20, 2025
9467e51
Update environment.py
paul-ri Jun 20, 2025
a90c7ae
Disable setup / teardown calls
paul-ri Jun 20, 2025
c70a33b
Disable Further setup
paul-ri Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions behave_django/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,21 @@ def setup_test(self, context):
This method runs the code necessary to create the test database, start
the live server, etc.
"""
if django.VERSION >= (5, 2):
context.test.__class__._pre_setup(run=True)
else:
context.test._pre_setup(run=True)
context.test.setUpClass()
#if django.VERSION >= (5, 2):
# context.test.__class__._pre_setup(run=True)
#else:
# context.test._pre_setup(run=True)
#context.test.setUpClass()
Copy link

@bittner bittner Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you comment this out?

context.test()

def teardown_test(self, context):
"""
Tears down the Django test
"""
context.test.tearDownClass()
context.test._post_teardown(run=True)
#context.test.tearDownClass()
#context.test._post_teardown(run=True)
#if context.test.doClassCleanups:
# context.test.doClassCleanups()
Comment on lines +125 to +126
Copy link

@bittner bittner Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in behave#164, instead of adding the cleanup code you should probably better make sure addClassCleanup is never executed to create cleanup tasks.

This is typically done by overriding the related class method by an empty implementation (see example).

del context.test


Expand Down
Loading
Loading