Commit 00f763b
authored
test: fix flaky drawer open and column sort timing issues (#15677)
### What
Fixed three flaky list view e2e tests: "should persist per-page limit in
list drawer", "should sort", and "should sort without resetting column
preferences".
<img width="1200" height="224" alt="Screenshot 2026-02-18 at 2 47 24 PM"
src="https://github.com/user-attachments/assets/ac4e2147-8925-4626-ab1f-8e33ab6c1a3e"
/>
### Why
The `drawer--is-open` and `sort-column--active` classes weren't applied
immediately after clicking buttons. Tests were checking visibility
before React finished re-rendering, causing intermittent timeouts in CI.
### How
Added explicit waits for drawer and sort button states before running
assertions. The drawer now waits for `state: 'visible'` after clicking
"Select posts", and the sortColumn helper waits for the active state on
sort buttons before checking the URL.1 parent a66e844 commit 00f763b
File tree
3 files changed
+29
-9
lines changed- test
- __helpers/e2e
- columns
- admin/e2e/list-view
3 files changed
+29
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
| 35 | + | |
32 | 36 | | |
33 | | - | |
34 | | - | |
35 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
36 | 40 | | |
37 | 41 | | |
38 | 42 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1628 | 1628 | | |
1629 | 1629 | | |
1630 | 1630 | | |
1631 | | - | |
| 1631 | + | |
| 1632 | + | |
| 1633 | + | |
1632 | 1634 | | |
1633 | 1635 | | |
| 1636 | + | |
1634 | 1637 | | |
1635 | 1638 | | |
1636 | 1639 | | |
| |||
1647 | 1650 | | |
1648 | 1651 | | |
1649 | 1652 | | |
1650 | | - | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
1651 | 1656 | | |
1652 | 1657 | | |
1653 | 1658 | | |
| |||
1670 | 1675 | | |
1671 | 1676 | | |
1672 | 1677 | | |
| 1678 | + | |
1673 | 1679 | | |
1674 | 1680 | | |
1675 | 1681 | | |
| |||
1783 | 1789 | | |
1784 | 1790 | | |
1785 | 1791 | | |
| 1792 | + | |
1786 | 1793 | | |
1787 | 1794 | | |
1788 | | - | |
| 1795 | + | |
| 1796 | + | |
| 1797 | + | |
| 1798 | + | |
| 1799 | + | |
| 1800 | + | |
1789 | 1801 | | |
1790 | 1802 | | |
1791 | 1803 | | |
| |||
0 commit comments