Skip to content

Commit 127e41a

Browse files
authored
fix(ui): relationship add button unsafe permissions property access (#14903)
### What? Fix crashing due to unsafe permissions property access in `AddNewRelation` by safely checking that a collection’s permissions exist before reading its `create` property. ### Why? Accessing `permissions.collections[slug].create` throws and breaks the UI when a collection’s permissions entry is missing. This happens for example when collection‑level access control makes that collection inaccessible. ### How? Change the condition to use optional chaining on the permissions, aligning with usage elsewhere in the codebase: - Before: `permissions.collections[relatedCollection?.slug].create` - After: `permissions.collections[relatedCollection?.slug]?.create`
1 parent 3a1eb77 commit 127e41a

File tree

1 file changed

+1
-1
lines changed
  • packages/ui/src/elements/AddNewRelation

1 file changed

+1
-1
lines changed

packages/ui/src/elements/AddNewRelation/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ export const AddNewRelation: React.FC<Props> = ({
193193
render={({ close: closePopup }) => (
194194
<PopupList.ButtonGroup>
195195
{relatedCollections.map((relatedCollection) => {
196-
if (permissions.collections[relatedCollection?.slug].create) {
196+
if (permissions.collections[relatedCollection?.slug]?.create) {
197197
return (
198198
<PopupList.Button
199199
className={`${baseClass}__relation-button--${relatedCollection?.slug}`}

0 commit comments

Comments
 (0)