Skip to content

Commit 8953b37

Browse files
fix: use consistent empty state styling between list and folder views (#15555)
### What? Uses the shared `NoListResults` component in the list view empty state, matching the styling already used by the folder and browse-by-folder views. ### Why? The empty state for the list view (left-aligned, no border) looks completely different from the folder view empty state (centered, dashed border). This inconsistency was reported in #15524. ### How? - Replaced the inline `collection-list__no-results` div in `DefaultListView` with the existing `NoListResults` component from `elements/NoListResults` - Removed the now-unused `&__no-results` SCSS block from `List/index.scss` - Updated e2e test selectors from `.collection-list__no-results` to `.no-results` #### Before <img width="1502" height="341" alt="Screenshot 2026-02-13 at 1 48 40 PM" src="https://github.com/user-attachments/assets/9e673a6b-f223-4793-a4ec-69c4d8aadfd8" /> <img width="1501" height="365" alt="Screenshot 2026-02-13 at 1 48 48 PM" src="https://github.com/user-attachments/assets/d2da1d41-10ac-44ac-869e-a6133dd1daf6" /> #### After <img width="1500" height="336" alt="Screenshot 2026-02-17 at 3 34 37 PM" src="https://github.com/user-attachments/assets/94e70bfe-e7ca-4a13-a193-dac8483ed646" /> <img width="1500" height="341" alt="Screenshot 2026-02-17 at 3 34 43 PM" src="https://github.com/user-attachments/assets/38e2a9f5-ac38-4b1b-a144-6775350a1048" /> Fixes #15524 --------- Co-authored-by: Patrik Kozak <35232443+PatrikKozak@users.noreply.github.com>
1 parent 9ae89dd commit 8953b37

File tree

57 files changed

+240
-89
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+240
-89
lines changed

packages/translations/src/clientKeys.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,8 @@ export const clientTranslationKeys = createClientTranslationKeys([
291291
'general:none',
292292
'general:noOptions',
293293
'general:noResults',
294+
'general:noResultsDescription',
295+
'general:noResultsFound',
294296
'general:notFound',
295297
'general:nothingFound',
296298
'general:noTrashResults',

packages/translations/src/languages/ar.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,8 @@ export const arTranslations: DefaultTranslationsObject = {
356356
noOptions: 'لا خيارات',
357357
noResults:
358358
'لا يوجد {{label}}. إما أن لا {{label}} موجودة حتى الآن أو لا تتطابق مع عوامل التصفية التي حددتها أعلاه.',
359+
noResultsDescription: 'إما أن لا يوجد شيء أو أنه لا يوجد شيء يطابق الفلاتر التي حددتها أعلاه.',
360+
noResultsFound: 'لا توجد نتائج.',
359361
notFound: 'غير موجود',
360362
nothingFound: 'لم يتم العثور على شيء',
361363
noTrashResults: 'لا {{label}} في المهملات.',

packages/translations/src/languages/az.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,9 @@ export const azTranslations: DefaultTranslationsObject = {
369369
noOptions: 'Heç bir seçim yoxdur',
370370
noResults:
371371
'Heç bir {{label}} tapılmadı. Ya hələ {{label}} yoxdur, ya da yuxarıda göstərdiyiniz filtrlərə uyğun gəlmir.',
372+
noResultsDescription:
373+
'Ya heç biri mövcud deyil, ya da yuxarıda göstərdiyiniz filtrlərə uyğun gəlmir.',
374+
noResultsFound: 'Nəticə yoxdur.',
372375
notFound: 'Tapılmadı',
373376
nothingFound: 'Heç nə tapılmadı',
374377
noTrashResults: 'Çöplükdə heç bir {{label}} yoxdur.',

packages/translations/src/languages/bg.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,9 @@ export const bgTranslations: DefaultTranslationsObject = {
366366
noOptions: 'Няма опции',
367367
noResults:
368368
'{{label}} не е открит. {{label}} не съществува или никой не отговаря на зададените филтри.',
369+
noResultsDescription:
370+
'Или не съществува такава, или никоя не отговаря на филтрите, които сте посочили по-горе.',
371+
noResultsFound: 'Няма резултати.',
369372
notFound: 'Няма открит',
370373
nothingFound: 'Нищо не беше открито',
371374
noTrashResults: 'Няма {{label}} в кошчето.',

packages/translations/src/languages/bnBd.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,9 @@ export const bnBdTranslations: DefaultTranslationsObject = {
371371
noOptions: 'কোনো বিকল্প নেই',
372372
noResults:
373373
'কোনো {{label}} পাওয়া যায়নি। হয় এখনও কোনো {{label}} তৈরি করা হয়নি বা উপরে নির্দিষ্ট করা ফিল্টারগুলির সাথে কোনোটি মেলে না।',
374+
noResultsDescription:
375+
'আপনার দেওয়া ফিল্টারের সাথে মিলে যায় এমন কোনও বিষয় উপস্থিত নেই বা মিলতে পারে এমন কোনও বিষয় বিদ্যমান নেই।',
376+
noResultsFound: 'ফলাফল নেই।',
374377
notFound: 'পাওয়া যায়নি',
375378
nothingFound: 'কিছুই পাওয়া যায়নি',
376379
noTrashResults: 'ট্র্যাশে কোন {{label}} নেই।',

packages/translations/src/languages/bnIn.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,9 @@ export const bnInTranslations: DefaultTranslationsObject = {
370370
noOptions: 'কোনো বিকল্প নেই',
371371
noResults:
372372
'কোনো {{label}} পাওয়া যায়নি। হয় এখনও কোনো {{label}} তৈরি করা হয়নি বা উপরে নির্দিষ্ট করা ফিল্টারগুলির সাথে কোনোটি মেলে না।',
373+
noResultsDescription:
374+
'আপনার উপরে নির্দিষ্ট ফিল্টারগুলির সাথে মেলে যায় এমন কোনো বিষয়টি নেই, অথবা সবচেয়ে সম্ভবত কোনো বিষয়টি নেই।',
375+
noResultsFound: 'ফলাফল নেই।',
373376
notFound: 'পাওয়া যায়নি',
374377
nothingFound: 'কিছুই পাওয়া যায়নি',
375378
noTrashResults: 'ট্র্যাশে কোনো {{label}} নেই।',

packages/translations/src/languages/ca.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,9 @@ export const caTranslations: DefaultTranslationsObject = {
368368
noOptions: 'Sense opcions',
369369
noResults:
370370
"No s'ha trobat cap {{label}}. O no n'hi ha cap encara o cap coincideix amb els filtres que has especificat anteriorment.",
371+
noResultsDescription:
372+
'O bé no en existeix cap o cap coincideix amb els filtres que heu especificat anteriorment.',
373+
noResultsFound: 'Sense resultats.',
371374
notFound: 'No trobat',
372375
nothingFound: 'Res trobat',
373376
noTrashResults: 'No hi ha cap {{label}} a la paperera.',

packages/translations/src/languages/cs.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,9 @@ export const csTranslations: DefaultTranslationsObject = {
365365
noOptions: 'Žádné možnosti',
366366
noResults:
367367
'Nebyly nalezeny žádné {{label}}. Buď ještě neexistují žádné {{label}}, nebo žádné nesplňují filtry, které jste zadali výše.',
368+
noResultsDescription:
369+
'Buď žádné neexistují, nebo žádné neodpovídají filtrům, které jste výše specifikovali.',
370+
noResultsFound: 'Žádné výsledky.',
368371
notFound: 'Nenalezeno',
369372
nothingFound: 'Nic nenalezeno',
370373
noTrashResults: 'Žádný {{label}} v koši.',

packages/translations/src/languages/da.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,9 @@ export const daTranslations: DefaultTranslationsObject = {
365365
noOptions: 'Ingen muligheder',
366366
noResults:
367367
'No {{label}} fundet. Enten findes der endnu ingen {{label}}, eller også matcher ingen af de filtre angivet ovenfor.',
368+
noResultsDescription:
369+
'Enten findes der ingen, eller ingen matcher de filtre, du har angivet ovenfor.',
370+
noResultsFound: 'Ingen resultater.',
368371
notFound: 'Ikke fundet',
369372
nothingFound: 'Intet fundet',
370373
noTrashResults: 'Ingen {{label}} i papirkurven.',

packages/translations/src/languages/de.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,9 @@ export const deTranslations: DefaultTranslationsObject = {
376376
noOptions: 'Keine Optionen',
377377
noResults:
378378
'Keine {{label}} gefunden. Entweder es existieren keine {{label}} oder es gibt keine Übereinstimmung zu den von dir verwendeten Filtern.',
379+
noResultsDescription:
380+
'Entweder existieren keine oder keine entsprechen den von Ihnen oben angegebenen Filtern.',
381+
noResultsFound: 'Keine Ergebnisse gefunden.',
379382
notFound: 'Nicht gefunden',
380383
nothingFound: 'Keine Ergebnisse',
381384
noTrashResults: 'Kein {{label}} im Papierkorb.',

0 commit comments

Comments
 (0)