test: deflakes localization e2e suite #14639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The localization e2e suite would use the
runCopyhelper function which copies data from 1 locale to another locale and then navigates to that locale.Tests would fail intermittently because they did not wait for that route change to happen. Scenarios would arise where the request took longer than the next
changeLocalecall which changes the locale and navigates to that locale.So it looked like:
runCopyis called but has not finishedchangeLocaleruns and navigates user to new localerunCopyfinishes and navigates to the locale it copied to