Skip to content

test: deflakes localization e2e suite #14639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
Merged

test: deflakes localization e2e suite #14639

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a72086d
test: deflakes localization e2e suite
JarrodMFlesch Nov 17, 2025
72d5496
chore: trigger CI
JarrodMFlesch Nov 17, 2025
d1339bd
adjust import
JarrodMFlesch Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions test/localization/e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
arrayWithFallbackCollectionSlug,
defaultLocale,
englishTitle,
hungarianLocale,
localizedDraftsSlug,
localizedPostsSlug,
relationshipLocalizedSlug,
Expand Down Expand Up @@ -404,7 +405,7 @@ describe('Localization', () => {
await createAndSaveDoc(page, url, { title })
await openCopyToLocaleDrawer(page)
await setToLocale(page, 'Spanish')
await runCopy(page)
await runCopy({ page, toLocale: spanishLocale })
await expect(page.locator('#field-title')).toHaveValue(title)
await changeLocale(page, defaultLocale)
})
Expand All @@ -419,7 +420,7 @@ describe('Localization', () => {

await openCopyToLocaleDrawer(page)
await setToLocale(page, 'Spanish')
await runCopy(page)
await runCopy({ page, toLocale: spanishLocale })

await expect(richTextField).toContainText(richTextContent)
})
Expand All @@ -438,7 +439,7 @@ describe('Localization', () => {

await openCopyToLocaleDrawer(page)
await setToLocale(page, 'English')
await runCopy(page)
await runCopy({ page, toLocale: defaultLocale })

await expect(arrayField).toHaveValue(sampleText)
})
Expand All @@ -465,7 +466,7 @@ describe('Localization', () => {
await setToLocale(page, 'Spanish')
const overwriteCheckbox = page.locator('#field-overwriteExisting')
await expect(overwriteCheckbox).not.toBeChecked()
await runCopy(page)
await runCopy({ page, toLocale: spanishLocale })

await expect(page.locator('#field-title')).toHaveValue(spanishTitle)
await expect(page.locator('#field-description')).toHaveValue('Spanish description')
Expand All @@ -482,7 +483,7 @@ describe('Localization', () => {
await setToLocale(page, 'Spanish')
const overwriteCheckbox = page.locator('#field-overwriteExisting')
await overwriteCheckbox.click()
await runCopy(page)
await runCopy({ page, toLocale: spanishLocale })
await expect(page.locator('#field-title')).toHaveValue(englishTitle)
await changeLocale(page, defaultLocale)
})
Expand All @@ -508,15 +509,15 @@ describe('Localization', () => {

await openCopyToLocaleDrawer(page)
await setToLocale(page, 'Spanish')
await runCopy(page)
await runCopy({ page, toLocale: spanishLocale })
await expect(page.locator('#field-title')).toHaveValue(title)

const regexPattern = /locale=es/
await expect(page).toHaveURL(regexPattern)

await openCopyToLocaleDrawer(page)
await setToLocale(page, 'Hungarian')
await runCopy(page)
await runCopy({ page, toLocale: hungarianLocale })
await expect(page.locator('#field-title')).toHaveValue(title)
})

Expand Down Expand Up @@ -797,8 +798,11 @@ async function fillValues(data: Partial<LocalizedPost>) {
}
}

async function runCopy(page) {
async function runCopy({ page, toLocale }: { page: Page; toLocale: string }) {
await page.locator('.copy-locale-data__sub-header button').click()

const regexPattern = new RegExp(`locale=${toLocale}`)
await expect(page).toHaveURL(regexPattern)
}

async function createAndSaveDoc(page, url, values) {
Expand Down
Loading