fix(plugin-multi-tenant): modal container blocks clicks on create-first-user page#15973
Merged
PatrikKozak merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
…debug and edit-many modes
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
…uginConfig.collections
Contributor
JarrodMFlesch
left a comment
There was a problem hiding this comment.
I think this PR is good, left tiny nit for seemingly unnecessary change.
packages/plugin-multi-tenant/src/components/TenantField/index.client.tsx
Show resolved
Hide resolved
JarrodMFlesch
approved these changes
Mar 17, 2026
Contributor
|
🚀 This is included in version v3.80.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the
@faceless-ui/modalcontainer blocking clicks on the/admin/create-first-userpage when the multi-tenant plugin is active. Also guards against the admin users collection being listed inpluginConfig.collections.Key Changes
openModalbehindshowFieldand early-return indebug/isEditManyModalOpenmodes — modal only opens when there are tenant options to displaypluginConfig.collections, with aconsole.warn— prevents double access control, conflicting tenant fields, and validation errors on user creationcollectionSlugsupfront to suppress the spurious missing-collections warningDesign Decisions
(!value && !selectedTenantID)had noshowFieldguard, soopenModalfired even with zero tenants. Oncreate-first-userthis left the modal container active withpointer-events: alland no content, blocking form clicks.users: {}inpluginConfig.collectionsis always a misconfiguration — Pass 1 already handles users viatenantsArrayField. Pass 2 processing them again adds a conflictingtenantFieldand breaks user creation. Warn-and-skip was chosen over a hard throw to stay non-breaking.Fixes #15288