Skip to content

fix(ui): use i18n for live preview "Open in new window" tooltip#16038

Merged
paulpopus merged 5 commits intopayloadcms:mainfrom
ruben-hutter:fix/i18n-live-preview-open-in-new-window
Apr 13, 2026
Merged

fix(ui): use i18n for live preview "Open in new window" tooltip#16038
paulpopus merged 5 commits intopayloadcms:mainfrom
ruben-hutter:fix/i18n-live-preview-open-in-new-window

Conversation

@ruben-hutter
Copy link
Copy Markdown
Contributor

The "Open in new window" title attribute in the live preview toolbar was hardcoded in English. Replace it with the existing openInNewTab translation key, which is already translated in all 44 supported languages.

The "Open in new window" title attribute in the live preview toolbar
was hardcoded in English. Replace it with the existing `openInNewTab`
translation key, which is already translated in all 44 supported
languages.
@ruben-hutter
Copy link
Copy Markdown
Contributor Author

Note: I used the existing openInNewTab key as it's the closest match available. However, the button actually opens a popup window (setPreviewWindowType('popup')), not a new tab. If you prefer a dedicated openInNewWindow key for accuracy, I'm happy to add it to all 44 language files instead.

@johnSmithTech

This comment was marked as spam.

Comment thread packages/ui/src/elements/LivePreview/Toolbar/Controls/index.tsx Outdated
@paulpopus paulpopus self-assigned this Apr 2, 2026
paulpopus
paulpopus previously approved these changes Apr 13, 2026
@paulpopus paulpopus merged commit 173b453 into payloadcms:main Apr 13, 2026
322 of 324 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🚀 This is included in version v3.83.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants