feat: make toast position configurable #14405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-tailor
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Extends the toast configuration introduced with payloadcms#13609 to also allow to configure the toast's positioning. The `position` configuration is a 1:1 pass-through of the https://sonner.emilkowal.ski `position` configuration option. The default remains unchanged compared to the status-quo, at `'bottom-right'`.
philipp-tailor
force-pushed
the
make-toast-position-configurable
branch
from
5629760 to
c13ffeb
Compare
|
🚀 This is included in version v3.62.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Extends the toast configuration introduced with #13609 to also allow to configure the toast's positioning.
Why?
Different users of Payload might prefer different positions. E.g. for our own implementation we'd prefer a top (central) position, because we've been having users overlook the toasts in the bottom right due to usage of large screens, and saving / publishing buttons usually triggering toasts being placed at the top (meaning the user looks at the top).
How?
The
positionconfiguration is a 1:1 pass-through of the https://sonner.emilkowal.skipositionconfiguration option. The default remains unchanged compared to the status-quo, at'bottom-right'.Screenshots
bottom-right: Unchanged to current placement.bottom-center:bottom-left:top-left- questionable, but IMHO that's fine because it's an opt-in choice.:top-center:top-left- also covers interactive UI, but is therefore very hard to overlook: