fix(next): removes reliance on instanceof from api error formatting #5482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes reliance on
instanceofwhen formatting API errors from the REST API. This led to field-level validation errors to not get properly formatted in API responses, i.e. unique fields do not receive their individual validation messages. The reason was because previously, we were checking the error'sinstanceofin order to properly format the response based onAPIError,ValidationError, etc. But changes to TS have made this condition unreliable (see https://dannyguo.medium.com/how-to-fix-instanceof-not-working-for-custom-errors-in-typescript-1df978100a27). Unfortunately the fix described in that article also does not resolve this issue, i.e. setting the prototype in the class' constructor. So instead, we check the name of the constructor explicitly. There might be a better fix for this in the future.This PR also fixing the casing on the
routeErrorfunction.