feat: fastlane html example #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbierdeman
force-pushed
the
feature/fastlane-html-example
branch
from
d353be3 to
9c3ca1e
Compare
nbierdeman
commented
Jun 4, 2025
| @@ -0,0 +1 @@ | |||
| 20.18.1 | |||
There was a problem hiding this comment.
I'm a fan of nvmrc files, but am cool with deleting this if there's opposition.
gregjopa
reviewed
Jun 4, 2025
gregjopa
reviewed
Jun 4, 2025
gregjopa
reviewed
Jun 4, 2025
gregjopa
reviewed
Jun 4, 2025
gregjopa
reviewed
Jun 5, 2025
|
Thanks for the feedback, @gregjopa! I went ahead and pushed those changes. 🤘 |
gregjopa
reviewed
Jun 5, 2025
gregjopa
reviewed
Jun 5, 2025
gregjopa
reviewed
Jun 5, 2025
| console.log("orderResponse: ", orderResponse); | ||
|
|
||
| if (orderResponse.status === "COMPLETED") { | ||
| alert("Order completed successfully! Check console for details."); |
There was a problem hiding this comment.
Is there any best practice to follow with fastlane after the order is complete? For example, hide the card form? Wondering what the other demos do for this use case.
There was a problem hiding this comment.
Let's keep it as is for now. We can always send a follow-up PR if we want to show a confirmation message
gregjopa
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
I tested this locally and it works for me! Happy to see this get merged. Nice work @nbierdeman 💯
EvanReinstein
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Fastlane demo covering both guest and member experiences.