Skip to content

Conversation

@ashraf-km
Copy link
Contributor

@ashraf-km ashraf-km commented Dec 23, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@ghost
Copy link

ghost commented Dec 23, 2020

Black Duck Security Report

Merging #48 into master will not change security risk.

Click here to see full report

@ashraf-km ashraf-km requested a review from solancer December 23, 2020 05:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c032c30 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (5% is the threshold).

This pull request will bring the total coverage in the repository to 99.5% (2.9% change).

View more on Code Climate.

@solancer solancer merged commit 3a6e075 into master Dec 23, 2020
@solancer solancer deleted the feature/addedUnitTest branch December 23, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants