Skip to content

Conversation

@k1LoW
Copy link
Contributor

@k1LoW k1LoW commented Oct 6, 2025

Fix #185

Hi,

Support for considering the OpenAPI version in response.ValidateResponseSchema and request.ValidateRequestSchema.

Each function signature contains a breaking change.

In ValidateRequestSchema and ValidateResponseSchema, I think the version should ideally be passed as a parameter via config.Option, but since all other functions were passing the version as an argument, I followed suit.
(For example, the intent of the arguments of helpers.NewCompiledSchemaWithVersion becomes unclear.)

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (c440fec) to head (26cab0e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   97.08%   97.09%           
=======================================
  Files          40       41    +1     
  Lines        4397     4403    +6     
=======================================
+ Hits         4269     4275    +6     
  Misses        128      128           
Flag Coverage Δ
unittests 97.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you.

@daveshanley
Copy link
Member

There are a couple of other PRs in the pipeline that also add some breaking changes, I want to group them all together so we have one big breaking release.

@daveshanley daveshanley merged commit 69c8af1 into pb33f:main Oct 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there any plan to reintroduce support for OpenAPI Spec 3.0 in responses.ValidateResponseSchema ?

2 participants