Skip to content

fix nullable values #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

fix nullable values #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9e38b
fix nullable values
ylebre Apr 24, 2025
c9408ef
Change optional parameters back to optional.
Potherca May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

class Exception extends \Exception
{
public static function create(string $error, array $context, \Exception $previous = null): Exception
public static function create(string $error, array $context, ?\Exception $previous = null): Exception
{
return new self(vsprintf($error, $context), 0, $previous);
}
Expand Down
8 changes: 6 additions & 2 deletions src/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ final public function setNotifications(SolidNotificationsInterface $notification
//////////////////////////////// PUBLIC API \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\

// @TODO: The Graph should be injected by the caller
final public function __construct(Filesystem $filesystem, Response $response, Graph $graph = null)
final public function __construct(Filesystem $filesystem, Response $response, ?Graph $graph = null)
{
$this->basePath = '';
$this->baseUrl = '';
Expand Down Expand Up @@ -588,6 +588,10 @@ private function handleCreateDirectoryRequest(Response $response, string $path):

private function sendNotificationUpdate($path, $type)
{
if (!isset($this->notifications)) {
return;
}

$baseUrl = $this->baseUrl;
$this->notifications->send($baseUrl . $path, $type);

Expand Down Expand Up @@ -788,7 +792,7 @@ private function listDirectoryAsTurtle($path)
// ACL and meta files should not be listed in directory overview
if (
$item['basename'] !== '.meta'
&& in_array($item['extension'], ['acl', 'meta']) === false
&& in_array($item['extension']??'', ['acl', 'meta']) === false
) {
try {
$linkMetadataResponse = $this->handleLinkMetadata(clone $this->response, $item['path']);
Expand Down