Skip to content

fix quote in value #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix quote in value #21

wants to merge 3 commits into from

Conversation

@lihz1990
Copy link

@lihz1990 lihz1990 commented Mar 8, 2018

#20

@lihz1990
Copy link
Author

lihz1990 commented Mar 9, 2018

Delete some unclean code in test case, it's another unfixed bug.

fulder added a commit to fulder/python-nginx that referenced this pull request Mar 30, 2018
@fulder
Add test from PR peakwinter#21 and issue peakwinter#20
406612f
@fulder
Copy link
Contributor

fulder commented Mar 30, 2018

The example code in #20 Still fails for me returning None in the test1 block.

I've merged your test case into my own PR #24 and added a test case for the issue in #20 and it seems to pass there.

@fulder fulder mentioned this pull request Mar 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lihz1990 @fulder