#55 - Fix issue with loading resource with Query parameters, it doesn… #66
Conversation
|
The task that is failing on the build process is about the babel version that is loaded is 6.X whereas the babel version that it is expected is 7.X.. This look like a build job configuration, any chance we can get that fixed? |
|
Hi there @alqh, thank you for your contribution. Excuse the late response. I modified your proposed changes to also work for cases where a resource path has explicit loaders and a query and added an additional test case. Regarding the CI error we decided to drop node 6 support. Are these changes ok for you? |
|
Hi @jannikkeye , thank you for picking up this PR. Your commit makes sense, I see the case where there are double-ups in the path and the iteration will just chop the last match one? Looks good to me, please go ahead @jannikkeye . Thank you.! |
jannikkeye
left a comment
jannikkeye
left a comment
There was a problem hiding this comment.
New changes approved after consultation of PR owner.
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you @jannikkeye for your time and help! |
|
@jannikkeye I picked up 4.0.1 version yesterday, but it is not loading the extract-loader, looks like there is no 'lib/extractLoader.js' which is the entry point to the extract-loader. Can you please verify your published build please? |
|
@alqh We switched to semantic-release but had some problems configuring it. Sorry for that 😞. We will release a fixed version today. |
|
@alqh Can you please install the latest version (should be 4.0.3). We fixed the semantic-release process so build assets are properly included before publishing: https://unpkg.com/extract-loader@4.0.3/lib/extractLoader.js |
|
@jannikkeye Thank you. I've pulled them and tested across our projects. Its working good now. Thank you !! |
|
@alqh Glad to hear it. 🎉 |
3 participants
…'t currently slice the path for query parameters