Add normalizer for WOF which can be configured to remove accents/hyphen and lowercase#33
Merged
missinglink merged 1 commit intomasterfrom Jun 5, 2019
Merged
Conversation
…emove accents/hyphen/spaces and do lowercase
Member
|
This is pretty cool 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In France, we have tons of localities with accents and hyphen and they aren't mandatory.
That's why we need to normalize them a bit more.
Supports for
Now Available
How it works
You can require the
normalizermodule which can be configured (it will return a configured function).Thanks to this, you don't need to give every time your options for the normalization.
I also added an option in wof resources to take a configured normalizer.
For now, this is only available for WOF, I need more use cases for others classifiers.