fix: enable event rbac #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmbill694
commented
Dec 9, 2025
| // +kubebuilder:scaffold:scheme | ||
| } | ||
|
|
||
| // GLOBAL RBAC FOR ENTIRE APPLICATION |
Collaborator
Author
There was a problem hiding this comment.
Just a little callout here. These comments that are used to generate RBAC by kubebuilder aren't location specific. Having them anywhere in the codebase means they get picked up. I would like to establish the convention though that if all controllers are going to use it a given resource (like events) that we put it in the main.go file
hmbill694
requested review from
chomatdam,
iveelsm,
seanmorton and
tallquist10
tallquist10
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During testing yesterday we noticed that there are RBAC errors occurring when creating events for the VMDIs. Under the hood events are "sibling" objects to the resources they reference and as such require their own explicit RBAC configuration.