Skip to content

Conversation

@joyliu-q
Copy link
Contributor

@joyliu-q joyliu-q commented Apr 12, 2022

Current blocked by pennlabs/infrastructure#155

  • After PR above is merged, make sure to update kittyhawk version in package.json

This PR does the following:

  • Transition from icarus to kittyhawk
  • Update kraken and regenerate deployment CI
  • Switch backend from DOMAIN to DOMAINS (list of domains supported)

To generate yaml, go into the k8s folder and run:

  • yarn build

Checklist

  • package.json in k8s folder is uniform
  • package.json in .github/cdk folder is uniform
  • renamed any mentions to DOMAIN in backend to DOMAINS
  • ran yarn build in k8s folder and compare new generated manifests w current

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #128 (4494a89) into master (d8e876d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          15       15           
  Lines         709      709           
=======================================
  Hits          692      692           
  Misses         17       17           
Flag Coverage Δ
backend 97.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e876d...4494a89. Read the comment docs.

@joyliu-q joyliu-q marked this pull request as ready for review April 19, 2022 18:41
@joyliu-q joyliu-q requested a review from jonathankao97 May 12, 2022 16:50
Copy link

@jonathankao97 jonathankao97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes but lgtm otherwise

Comment on lines +14 to +16
"build": "npm run compile && npm run synth",
"upgrade": "npm i cdk8s@latest cdk8s-cli@latest",
"upgrade:next": "npm i cdk8s@next cdk8s-cli@next"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor but should we be mixing yarn and npm commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running yarn build runs npm under the hood.

k8s/package.json Outdated
"synth": "cdk8s synth",
"compile": "tsc",
"watch": "tsc -w",
"test": "jest",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also minor but not sure how this command is being used, not seeing any tests or jest config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, jest was added automatically when creating the project but deleted later. Thanks!

@joyliu-q joyliu-q merged commit 8545148 into master May 13, 2022
@joyliu-q joyliu-q deleted the feature/update-to-kittyhawk branch May 13, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants