-
Notifications
You must be signed in to change notification settings - Fork 2
Use Kittyhawk for Deployment Config #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 15 15
Lines 709 709
=======================================
Hits 692 692
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jonathankao97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes but lgtm otherwise
| "build": "npm run compile && npm run synth", | ||
| "upgrade": "npm i cdk8s@latest cdk8s-cli@latest", | ||
| "upgrade:next": "npm i cdk8s@next cdk8s-cli@next" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor but should we be mixing yarn and npm commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running yarn build runs npm under the hood.
k8s/package.json
Outdated
| "synth": "cdk8s synth", | ||
| "compile": "tsc", | ||
| "watch": "tsc -w", | ||
| "test": "jest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also minor but not sure how this command is being used, not seeing any tests or jest config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, jest was added automatically when creating the project but deleted later. Thanks!
Current blocked by pennlabs/infrastructure#155
This PR does the following:
DOMAINtoDOMAINS(list of domains supported)To generate yaml, go into the
k8sfolder and run:yarn buildChecklist
k8sfolder is uniform.github/cdkfolder is uniformDOMAINin backend toDOMAINSyarn buildink8sfolder and compare new generated manifests w current