Depublicate queries retrieve builder view #158

moumoutte · 2017-01-15T16:54:26Z

/!\ Waiting for #154 to be merged in order to introduce django_perf_rec

On master

+UpdateFormTestCase.test_queryset_on_get:
+- db: 'SELECT ... FROM "formidable_formidable" WHERE "formidable_formidable"."id" = #'
+- db: SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" IN (#) ORDER BY "formidable_field"."order" ASC
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'
+RenderSerializerTestCase.test_queryset:
+- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" = #'
+- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'

On current branch

+RenderSerializerTestCase.test_queryset:
+- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
+- db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC
+- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)
+- db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...)
+- db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" IN (...)
+- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'
+UpdateFormTestCase.test_queryset_on_get:
+- db: 'SELECT ... FROM "formidable_formidable" WHERE "formidable_formidable"."id" = #'
+- db: SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" IN (#) ORDER BY "formidable_field"."order" ASC
+- db: 'SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC'
+- db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC
+- db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...)
+- db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...)
+- db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" IN (...)
+- db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #'

until the sqllite driver is not compatible with django_perf_rec adamchainz/django-perf-rec#50, we have to provide an overrided sqllite driver backend to be able to record verbosely each recorded SQL line.

brunobord · 2017-01-16T16:44:59Z

superseded by #163

Changelog * Added a make target to install the demo site (#152). * Added django-perf-rec module for tests and improved SQL queries in `ContextFormDetailView` (#54, #154, #160). * Added test to count queries on dynamic form queryset + improve performances (#155, #156, #162). * Added test to count queries on retrieve builder view + improve performances by removing duplicate queries (#157, #158, #163).

moumoutte added 7 commits January 15, 2017 16:02

refs #54, add django perf rec into django-formidable

8016754

until the sqllite driver is not compatible with django_perf_rec adamchainz/django-perf-rec#50, we have to provide an overrided sqllite driver backend to be able to record verbosely each recorded SQL line.

refs #54, add sql test recorder on retrieve context form from API

d0a3437

refs #54, disambiguate the URL's in order to fetch context form

174ff03

refs #54, order items in the fields serializer

0ddc5a6

refs #54, order fields in form serializer

870ef95

refs #54, add sql tests on serializer only

b152027

refs #54, use the prefetch to check access directly

22f82f6

moumoutte changed the title ~~157 depublicate queries retrieve builder view~~ [WIP] Depublicate queries retrieve builder view Jan 15, 2017

moumoutte force-pushed the 157_depublicate_queries_retrieve_builder_view branch 3 times, most recently from 720c743 to b21f869 Compare January 15, 2017 17:04

moumoutte added 4 commits January 15, 2017 18:08

refs #157, add test on builder retrieve view

a126404

refs #157, add test on serializer only

1f72e02

refs #157, Use prefetch related in serializer

0f057b2

refs #157, add sql test file complete

9aae65a

moumoutte force-pushed the 157_depublicate_queries_retrieve_builder_view branch from b21f869 to 9aae65a Compare January 15, 2017 17:08

moumoutte changed the title ~~[WIP] Depublicate queries retrieve builder view~~ Depublicate queries retrieve builder view Jan 15, 2017

moumoutte closed this Jan 16, 2017

brunobord reopened this Jan 16, 2017

brunobord mentioned this pull request Jan 16, 2017

Deduplicate queries retrieve builder view #163

Merged

4 tasks

brunobord closed this Jan 16, 2017

brunobord mentioned this pull request Jan 17, 2017

v0.6.0 #164

Merged

moumoutte deleted the 157_depublicate_queries_retrieve_builder_view branch February 20, 2017 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Depublicate queries retrieve builder view #158

Depublicate queries retrieve builder view #158

Uh oh!

moumoutte commented Jan 15, 2017 •

edited

Loading

Uh oh!

brunobord commented Jan 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Depublicate queries retrieve builder view #158

Depublicate queries retrieve builder view #158

Uh oh!

Conversation

moumoutte commented Jan 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunobord commented Jan 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

moumoutte commented Jan 15, 2017 •

edited

Loading