[setup] Expose version in formidable package #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the version is set in `setup.py`, it's not available in formidable module itself. I suggest to set the version in formidable/__init__.py instead.
moumoutte
approved these changes
Jan 16, 2017
brunobord
reviewed
Jan 16, 2017
| setup( | ||
| name='django-formidable', | ||
| version='0.6.0.dev0', | ||
| version=formidable.version, |
There was a problem hiding this comment.
will it work when installing the package on a fresh venv? can you really import your package before installing it?
There was a problem hiding this comment.
I saw this pattern several times, so I think it's safe.
Alternatively, we could use bumpversion package to dump the new version in both files.
There was a problem hiding this comment.
I remember it was tricky to have the version in .py files ; that's the reason why we used to use VERSION files. But if it works, then go.
There was a problem hiding this comment.
CircleCI didn't have an issue installing django-formidable using tox -r.
I'll revert this commit if it causes any issue.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Since the version is set in
setup.py, it's not available in formidablemodule itself. I suggest to set the version in
formidable/__init__.pyinstead.