Skip to content

[models] Add str() methods #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2017
Merged

[models] Add str() methods #167

merged 1 commit into from
Jan 31, 2017

Conversation

wo0dyn
Copy link
Contributor

@wo0dyn wo0dyn commented Jan 30, 2017

µPR

@wo0dyn wo0dyn self-assigned this Jan 30, 2017
@wo0dyn wo0dyn requested review from brunobord and moumoutte January 30, 2017 15:30
@wo0dyn wo0dyn force-pushed the models/add-__unicode__-methods branch from ec6ab45 to c882b4b Compare January 30, 2017 15:32
@brunobord
Copy link
Contributor

thats cool... where are your tests? ;o)

@wo0dyn wo0dyn force-pushed the models/add-__unicode__-methods branch 2 times, most recently from 83dbb75 to b56113d Compare January 31, 2017 01:28
@wo0dyn wo0dyn changed the title [models] Add unicode methods [models] Add str() methods Jan 31, 2017
@wo0dyn
Copy link
Contributor Author

wo0dyn commented Jan 31, 2017

where are your tests?

Tests added.
I renamed the method to __str__() so it can be compatible with both python2 and python3.

brunobord
brunobord approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you may want to add a changelog entry if you want.

@wo0dyn
[models] Add str() methods
9b2de21 
It is pretty usefull when debugging objects.
@wo0dyn wo0dyn force-pushed the models/add-__unicode__-methods branch from b56113d to 9b2de21 Compare January 31, 2017 08:23
@wo0dyn
Copy link
Contributor Author

wo0dyn commented Jan 31, 2017

you may want to add a changelog entry if you want.

ChangeLog amended with the previous PR #166 and this one.

@wo0dyn wo0dyn merged commit c85e76c into master Jan 31, 2017
@wo0dyn wo0dyn deleted the models/add-__unicode__-methods branch January 31, 2017 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moumoutte moumoutte Awaiting requested review from moumoutte

1 more reviewer

@brunobord brunobord brunobord approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wo0dyn wo0dyn

Labels

3 - Review Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wo0dyn @brunobord