Provide a tools in order to generate django-form class from json contextualized definition #171

moumoutte · 2017-02-12T20:42:14Z

Use case

When the contextualized schema is already stored in database (First step to reach the versioning directly in formidable) generate the associated django form class.

Used with Contextualized definition

schema = ContextFormSerializer(instance=formidable, context={
    'role': 'jedi'
}).data

form_class = get_dynamic_form_class_from_schema(schema)
form = form_class(data={'first_name': 'Obiwan', 'last_name': 'Kenobi'})
form.is_valid()

Remaining Standard Fields to Handle

Radio
Radio Button (I'm really asking if we need to handle it in formidable, because it's not a standard input, it's specific needed for peopleask)
Checkboxes

Remaining Format Field to handle

Help Text
Separator Field
Title

brunobord · 2017-02-13T09:02:31Z

demo/tests/test_form_from_schema.py

+        schema = ContextFormSerializer(instance=formidable, context={
+            'role': 'jedi'
+        }).data
+        form = get_dynamic_form_class_from_schema(schema)()


what is it here? a form instance or a class?

From what I understood: get_dynamic_form_class_from_schema(schema) is a class, so get_dynamic_form_class_from_schema(schema)() is an instance.

brunobord

I like this new tool in our toolbox. although, I'd recommend to rename the "form" variable in the test to reflect its true nature: it's a form_class object, rather than a "ready to use" form instance.
It'll make the tests more readable

brunobord · 2017-02-13T09:08:24Z

formidable/forms/__init__.py


+def get_dynamic_form_class_from_schema(schema, field_factory=None):
+    """
+    Schema Already contextualized


I'm not a fan of this docstring. maybe it could be a bit more consistent, using a simple code sample, for example? And the first line should read:

Return a dynamically generated and contextualized form class

brunobord · 2017-02-13T09:11:30Z

formidable/forms/field_builder.py

+        if role:
+            # The role is previously "prefetch" in order to avoid database
+            # hit, we don't use a get() method in queryset.
+            return self.field.accesses.all()[0]


what happens here if the field.accesses.all() is empty?

I'm not sure, but if field.accesses.all() is a queryset, you can use .first() that'll eventually return None if the queryset is empty. (but I don't know if it has side effects)

The role is previously "prefetch" in order to avoid database
hit, we don't use a get() method in queryset"

Not sur first will not hit the database with prefetch related call before.

+1 for .first()

FYI
https://github.com/novafloss/django-formidable/blob/master/formidable/forms/__init__.py#L83

When using "first" instead of "all()[0]"

====================================================================== FAIL: test_queryset_without_role (tests.test_forms.TestDynamicForm) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/moumoutte/projects/django-formidable/demo/tests/test_forms.py", line 305, in test_queryset_without_role form.get_django_form_class(role='jedi') File "/home/moumoutte/.virtualenvs/formidable/local/lib/python2.7/site-packages/django_perf_rec/api.py", line 91, in __exit__ self.save_or_assert() File "/home/moumoutte/.virtualenvs/formidable/local/lib/python2.7/site-packages/django_perf_rec/api.py", line 127, in save_or_assert assert self.record == orig_record, msg AssertionError: Performance record did not match for TestDynamicForm.test_queryset_without_role db: SELECT ... FROM "formidable_field" WHERE "formidable_field"."form_id" = # ORDER BY "formidable_field"."order" ASC db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC db: SELECT ... FROM "formidable_access" WHERE ("formidable_access"."access_id" = # AND "formidable_access"."field_id" IN (...)) db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...) db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...) + db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = # ORDER BY "formidable_access"."id" ASC LIMIT # + db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = # ORDER BY "formidable_access"."id" ASC LIMIT # + db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = # ORDER BY "formidable_access"."id" ASC LIMIT # + db: SELECT ... FROM "formidable_access" WHERE "formidable_access"."field_id" = # ORDER BY "formidable_access"."id" ASC LIMIT # db: SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #

moumoutte · 2017-02-13T09:32:00Z

it's a form_class

It's not.

moumoutte · 2017-02-14T10:56:24Z

Need #173 in order to continue.

Changes requested addressed

mgu · 2017-04-06T08:13:57Z

formidable/forms/field_builder_from_schema.py

+
+class FormFieldFactory(BaseFormFieldFactory):
+
+    field_map = {


you could add a test to ensure that this map has the same keys as field_builder.FormFieldFactory.field_map

Test added in 87d1cac.

Instead of using acronyms, we use verbose name prefixed with `Base`.

wo0dyn · 2017-04-11T04:04:38Z

Ready for review once again.

mgu

LGTM, nice work !

ChangeLog --------- * Added Django 1.10 support (#203). * Dropped Python 3.3 support (#207). * Fixed the swagger doc generation and rendering (#210). * Fix wrong field type for Checkbox (#208). * Don't rely on database ordering in `NestedListSerializer` (#215) * Provide a tools in order to generate django-form class from json contextualized definition (#171)

moumoutte force-pushed the 170_form_class_from_json branch 3 times, most recently from 13e1213 to bff7624 Compare February 12, 2017 21:42

brunobord reviewed Feb 13, 2017

View reviewed changes

brunobord previously requested changes Feb 13, 2017

View reviewed changes

brunobord reviewed Feb 13, 2017

View reviewed changes

moumoutte force-pushed the 170_form_class_from_json branch 3 times, most recently from 9d21e02 to c4db3b8 Compare February 26, 2017 18:27

wo0dyn changed the title ~~[WIP] Provide a tools in order to generate django-form class from json contextualized definition~~ Provide a tools in order to generate django-form class from json contextualized definition Mar 6, 2017

wo0dyn self-assigned this Mar 6, 2017

wo0dyn added the 3 - Review label Mar 6, 2017

wo0dyn force-pushed the 170_form_class_from_json branch 4 times, most recently from 84673c7 to 18f9120 Compare March 24, 2017 15:17

mgu reviewed Apr 6, 2017

View reviewed changes

moumoutte added 9 commits April 11, 2017 05:56

refs #170, Add field builder from schema

08f62c7

refs #170, Add related tests to paragraph and text field

51caf6f

refs #170, Remove accesses computation from contextualized schema

ba34ef1

refs #170, Add checkbox

ed5792c

refs #170, Add email field

9d65403

refs #170, Add integer field

cf61e29

refs #170, Add filefield support

f6dfd9b

refs #170, Add date field support

a2449cc

refs #170, Mock the global rules generation in form

79ccf25

moumoutte and others added 17 commits April 11, 2017 05:56

refs #170, Refactorize ValidatorFactory

e46597f

refs #170, Add method to subclass in field builder

2410579

refs #170, Generate validator

ce2db34

refs #170, Add test for validations

546d3d5

refs #170, Add date validator factory

8a07f13

refs #170, Use the correct method to build rules from schema

6bbb04f

refs #170, Add a method to build rules from schema

a002f80

refs #170, Add test on presets generated from schema

e6a5c76

refs #170, Add dropdown builder

9264f6d

refs #170, Use intermediate variable for instancing form class

e388ab1

refs #170, Use generator for get_choices()

a995c9d

refs #170, Add radios field

228dae8

refs #170, Add help-text field

c492043

refs #170, Add separator field

afdac3d

refs #170, Use verbose aliases for imports

b12f92c

Instead of using acronyms, we use verbose name prefixed with `Base`.

refs #170, Add button radios field

80be6d4

refs #170, Add mapping test

87d1cac

wo0dyn force-pushed the 170_form_class_from_json branch from dc6bc26 to 87d1cac Compare April 11, 2017 03:57

refs #170, Update ChangeLog

86fe8a9

mgu approved these changes Apr 11, 2017

View reviewed changes

wo0dyn merged commit 3e7d7aa into master Apr 11, 2017

wo0dyn deleted the 170_form_class_from_json branch April 11, 2017 08:57

This was referenced Apr 11, 2017

Release version 0.9.0 #217

Merged

Tools in order to build Django Form class from serialized data #170

Closed

xcambar unassigned wo0dyn Nov 27, 2017

Provide a tools in order to generate django-form class from json contextualized definition #171

Provide a tools in order to generate django-form class from json contextualized definition #171

Uh oh!

Conversation

moumoutte commented Feb 12, 2017 • edited by wo0dyn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use case

Used with Contextualized definition

Remaining Standard Fields to Handle

Remaining Format Field to handle

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brunobord left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moumoutte Feb 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moumoutte Feb 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moumoutte commented Feb 13, 2017

Uh oh!

moumoutte commented Feb 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wo0dyn commented Apr 11, 2017

Uh oh!

mgu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moumoutte commented Feb 12, 2017 •

edited by wo0dyn

Loading

moumoutte Feb 13, 2017 •

edited

Loading

moumoutte Feb 13, 2017 •

edited

Loading