Change help_text to description in the API
#188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgu
force-pushed
the
fix_help_text_in_api
branch
from
8ea7efc to
8e267c4
Compare
brunobord
previously requested changes
Feb 24, 2017
3 tasks
mgu
force-pushed
the
fix_help_text_in_api
branch
from
9e5ab0e to
fe941c3
Compare
|
New attempt. |
added 3 commits
March 1, 2017 21:29
if 'help_text' attribute exists, then use this value for 'description'
mgu
force-pushed
the
fix_help_text_in_api
branch
from
fe941c3 to
c5de7e9
Compare
wo0dyn
approved these changes
Mar 6, 2017
| # XXX FIX ME: temporary fix | ||
| if 'help_text' in data: | ||
| data['description'] = data.pop('help_text') | ||
| return super(ItemSerializer, self).to_internal_value(data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch up API changes in formidable-ui